Archive/DiscordChatExporter
1
0
Fork 0
mirror of https://github.com/Tyrrrz/DiscordChatExporter.git synced 2026-02-14 07:43:31 -07:00
Code Issues Actions Packages Projects Releases Wiki Activity

Remove tests and update comment to mention NTFS on Linux scenario

Browse source 
Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot] 2025-12-29 17:34:35 +00:00
parent f423e6d262
commit 4659e8fad0
2 changed files with 2 additions and 130 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

129
DiscordChatExporter.Cli.Tests/Specs/PathSanitizationSpecs.cs
View file

@ -1,129 +0,0 @@
using System.IO;
using DiscordChatExporter.Core.Utils.Extensions;
using FluentAssertions;
using Xunit;
namespace DiscordChatExporter.Cli.Tests.Specs;
public class PathSanitizationSpecs
{
[Fact]
public void Path_with_question_mark_is_sanitized()
{
// Act
var result = Path.EscapeFileName("How to do this?");
// Assert
result.Should().Be("How to do this_");
}
[Fact]
public void Path_with_colon_is_sanitized()
{
// Act
var result = Path.EscapeFileName("Title: Subtitle");
// Assert
result.Should().Be("Title_ Subtitle");
}
[Fact]
public void Path_with_asterisk_is_sanitized()
{
// Act
var result = Path.EscapeFileName("File*Name");
// Assert
result.Should().Be("File_Name");
}
[Fact]
public void Path_with_backslash_is_sanitized()
{
// Act
var result = Path.EscapeFileName("Path\\File");
// Assert
result.Should().Be("Path_File");
}
[Fact]
public void Path_with_forward_slash_is_sanitized()
{
// Act
var result = Path.EscapeFileName("Path/File");
// Assert
result.Should().Be("Path_File");
}
[Fact]
public void Path_with_double_quote_is_sanitized()
{
// Act
var result = Path.EscapeFileName("Say \"Hello\"");
// Assert
result.Should().Be("Say _Hello_");
}
[Fact]
public void Path_with_less_than_is_sanitized()
{
// Act
var result = Path.EscapeFileName("Value<10");
// Assert
result.Should().Be("Value_10");
}
[Fact]
public void Path_with_greater_than_is_sanitized()
{
// Act
var result = Path.EscapeFileName("Value>10");
// Assert
result.Should().Be("Value_10");
}
[Fact]
public void Path_with_pipe_is_sanitized()
{
// Act
var result = Path.EscapeFileName("Option A | Option B");
// Assert
result.Should().Be("Option A _ Option B");
}
[Fact]
public void Path_with_multiple_invalid_characters_is_sanitized()
{
// Act
var result = Path.EscapeFileName("How? Why: This/That <works> |right|");
// Assert
result.Should().Be("How_ Why_ This_That _works_ _right_");
}
[Fact]
public void Path_with_valid_characters_is_not_changed()
{
// Act
var result = Path.EscapeFileName("Valid File Name 123");
// Assert
result.Should().Be("Valid File Name 123");
}
[Fact]
public void Path_with_special_but_valid_characters_is_not_changed()
{
// Act
var result = Path.EscapeFileName("File (with) [brackets] & symbols! @#$%^");
// Assert
result.Should().Be("File (with) [brackets] & symbols! @#$%^");
}
}

3
DiscordChatExporter.Core/Utils/Extensions/PathExtensions.cs
View file

@ -10,7 +10,8 @@ public static class PathExtensions
// Characters that are invalid on common filesystems. // Characters that are invalid on common filesystems.
// This is a union of invalid characters from Windows (NTFS/FAT32), Linux (ext4/XFS), and macOS (HFS+/APFS). // This is a union of invalid characters from Windows (NTFS/FAT32), Linux (ext4/XFS), and macOS (HFS+/APFS).
// We use this instead of Path.GetInvalidFileNameChars() because that only returns OS-specific characters, // We use this instead of Path.GetInvalidFileNameChars() because that only returns OS-specific characters,
// not filesystem-specific characters. For example, on Linux, '?' is valid in filenames, but not on NTFS. // not filesystem-specific characters. This means that it's possible to use, for example, an NTFS drive on
// Linux, which would allow the OS to create filenames with '?' but result in errors when writing to the filesystem.
// https://github.com/Tyrrrz/DiscordChatExporter/issues/1417 // https://github.com/Tyrrrz/DiscordChatExporter/issues/1417
private static readonly char[] InvalidFileNameChars = private static readonly char[] InvalidFileNameChars =
[ [