Archive/DiscordChatExporter
1
0
Fork 0
mirror of https://github.com/Tyrrrz/DiscordChatExporter.git synced 2026-02-15 00:03:38 -07:00
Code Issues Actions Packages Projects Releases Wiki Activity

Don't throw if file dates cannot be modified when downloading media

Browse source 
Fixes #585
This commit is contained in:
Tyrrrz 2021-06-14 20:43:44 +03:00
parent cbe4bc593c
commit bd40dbde48
1 changed files with 22 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

32
DiscordChatExporter.Core/Exporting/MediaDownloader.cs
View file

@ -45,7 +45,7 @@ namespace DiscordChatExporter.Core.Exporting
Directory.CreateDirectory(_workingDirPath); Directory.CreateDirectory(_workingDirPath);
// This catches IOExceptions which is dangerous as we're working also with files // This retries on IOExceptions which is dangerous as we're also working with files
await Http.ExceptionPolicy.ExecuteAsync(async () => await Http.ExceptionPolicy.ExecuteAsync(async () =>
{ {
// Download the file // Download the file
@ -56,17 +56,27 @@ namespace DiscordChatExporter.Core.Exporting
} }
// Try to set the file date according to the last-modified header // Try to set the file date according to the last-modified header
var lastModified = response.Content.Headers.TryGetValue("Last-Modified")?.Pipe(s => try
DateTimeOffset.TryParse(s, CultureInfo.InvariantCulture, DateTimeStyles.None, out var date)
? date
: (DateTimeOffset?) null
);
if (lastModified is not null)
{ {
File.SetCreationTimeUtc(filePath, lastModified.Value.UtcDateTime); var lastModified = response.Content.Headers.TryGetValue("Last-Modified")?.Pipe(s =>
File.SetLastWriteTimeUtc(filePath, lastModified.Value.UtcDateTime); DateTimeOffset.TryParse(s, CultureInfo.InvariantCulture, DateTimeStyles.None, out var date)
File.SetLastAccessTimeUtc(filePath, lastModified.Value.UtcDateTime); ? date
: (DateTimeOffset?) null
);
if (lastModified is not null)
{
File.SetCreationTimeUtc(filePath, lastModified.Value.UtcDateTime);
File.SetLastWriteTimeUtc(filePath, lastModified.Value.UtcDateTime);
File.SetLastAccessTimeUtc(filePath, lastModified.Value.UtcDateTime);
}
}
catch
{
// This can apparently fail for some reason.
// https://github.com/Tyrrrz/DiscordChatExporter/issues/585
// Updating file dates is not a critical task, so we'll just
// ignore exceptions thrown here.
} }
}); });