From c713ee5e64431f79c07caef25df1e22062304669 Mon Sep 17 00:00:00 2001 From: Boden Date: Fri, 29 May 2026 13:54:46 -0500 Subject: [PATCH] docs(review): record residual review findings --- docs/residual-review-findings/feat-recurring-cli-scrape.md | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 docs/residual-review-findings/feat-recurring-cli-scrape.md diff --git a/docs/residual-review-findings/feat-recurring-cli-scrape.md b/docs/residual-review-findings/feat-recurring-cli-scrape.md new file mode 100644 index 00000000..3a5c6dd3 --- /dev/null +++ b/docs/residual-review-findings/feat-recurring-cli-scrape.md @@ -0,0 +1,7 @@ +## Residual Review Findings + +Source: ce-code-review autofix pass on `docs/plans/2026-05-29-011-feat-documents-recurring-scrape-verify-plan.md` + +- **[P2][manual]** `scripts/run-discord-scrape.sh` (`last_message_id`) — `max_by(.id)` uses string comparison; mixed-length snowflakes can pick wrong cursor and re-fetch history. Suggested fix: `sort_by(.id) | last | .id` or padded numeric compare. +- **[P3][manual]** `scripts/run-discord-scrape.sh` (`load_guild_channel_cache`) — Channel listing failures exit without CLI stderr context. Mirror `load_guild_cache` error capture. +- **[P3][advisory]** `docker-compose.yml` — `DCE_ARCHIVE_ROOT` defaults to `/home/brunner56/Documents`; set explicitly on other hosts.