Archive/DiscordChatExporter
1
0
Fork 0
mirror of https://github.com/Tyrrrz/DiscordChatExporter.git synced 2026-06-10 00:02:37 -06:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(review): apply autofix feedback

Browse source 
Correct merge dateRange.before preference, preflight log accuracy,
and remove dead failed_channels path in scrape_target.
This commit is contained in:
Boden 2026-05-29 13:54:36 -05:00
parent 90bd9da143
commit ef9aa90bb0
1 changed files with 2 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
scripts/run-discord-scrape.sh
View file

@ -463,7 +463,7 @@ merge_exports() {
) )
| .dateRange = { | .dateRange = {
after: ($existing.dateRange.after // $incremental.dateRange.after), after: ($existing.dateRange.after // $incremental.dateRange.after),
before: ($existing.dateRange.before // $incremental.dateRange.before) before: ($incremental.dateRange.before // $existing.dateRange.before)
} }
| .exportedAt = ($incremental.exportedAt // $existing.exportedAt) | .exportedAt = ($incremental.exportedAt // $existing.exportedAt)
| if ($existing | has("messageCount")) or ($incremental | has("messageCount")) | if ($existing | has("messageCount")) or ($incremental | has("messageCount"))
@ -722,7 +722,7 @@ preflight_target() {
preflight_probe_channel "$probe_channel_id" "$output_dir" || probe_status=$? preflight_probe_channel "$probe_channel_id" "$output_dir" || probe_status=$?
case "$probe_status" in case "$probe_status" in
0) 0)
log "Preflight ok for target '$target_name': ${#channel_ids[@]} channel(s) resolved for $output_dir." log "Preflight ok for target '$target_name': token verified (${#channel_ids[@]} channel(s) resolved, probe succeeded on $probe_channel_id) for $output_dir."
return 0 return 0
;; ;;
2) 2)
@ -766,7 +766,6 @@ scrape_target() {
local channel_id local channel_id
local skipped_channels=0 local skipped_channels=0
local failed_channels=0
for channel_id in "${channel_ids[@]}"; do for channel_id in "${channel_ids[@]}"; do
destination_path=$(resolve_destination_path "$output_dir" "$channel_id") destination_path=$(resolve_destination_path "$output_dir" "$channel_id")
if [[ -n "$destination_path" ]]; then if [[ -n "$destination_path" ]]; then
@ -797,7 +796,6 @@ scrape_target() {
;; ;;
*) *)
rm -rf "$temp_dir" rm -rf "$temp_dir"
failed_channels=$((failed_channels + 1))
die "Channel $channel_id failed for target '$target_name'." die "Channel $channel_id failed for target '$target_name'."
;; ;;
esac esac
@ -833,9 +831,6 @@ scrape_target() {
if (( skipped_channels > 0 )); then if (( skipped_channels > 0 )); then
log "Target '$target_name': skipped $skipped_channels inaccessible channel(s)." log "Target '$target_name': skipped $skipped_channels inaccessible channel(s)."
fi fi
if (( failed_channels > 0 )); then
die "Target '$target_name': $failed_channels channel(s) failed."
fi
log "Target '$target_name': scrape completed successfully." log "Target '$target_name': scrape completed successfully."
} }