From 870109e93a6ff0332543b9bc00046a6929b57de1 Mon Sep 17 00:00:00 2001 From: Chrystian Huot Date: Sun, 23 Aug 2020 08:06:54 -0400 Subject: [PATCH] Fix beep method not completing promise in some situation --- CHANGELOG.md | 1 + .../app/components/rdio-scanner/rdio-scanner.service.ts | 8 +++++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 818a69d..1cef605 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ - Change config.options.useDimmer to config.options.dimmerDelay. - Fix potential error in handling keypadBeeps styles. - Change handling of skip delay on client. +- Fix beep method not completing promise in some situation. # Version 4.6 diff --git a/client/src/app/components/rdio-scanner/rdio-scanner.service.ts b/client/src/app/components/rdio-scanner/rdio-scanner.service.ts index 9f4d1c9..d15416e 100644 --- a/client/src/app/components/rdio-scanner/rdio-scanner.service.ts +++ b/client/src/app/components/rdio-scanner/rdio-scanner.service.ts @@ -179,7 +179,13 @@ export class AppRdioScannerService implements OnDestroy { const gn = context.createGain(); - const seq = this.config?.keypadBeeps[style] || []; + const seq = this.config?.keypadBeeps[style]; + + if (!Array.isArray(seq) || !seq.length) { + resolve(); + + return; + } gn.gain.value = .1;