Archive/screentinker
1
0
Fork 0
mirror of https://github.com/screentinker/screentinker.git synced 2026-08-13 22:03:13 -06:00
Code Issues Actions 10 Packages Projects Releases Wiki Activity

fix(android): visible D-pad focus stroke on setup buttons (#218)

Browse source 
The setup screen buttons used a bare <ripple> which only reacts to
state_pressed (touch). D-pad navigation triggers state_focused, which the
ripple ignored, leaving the focused button nearly invisible against the
dark background from TV viewing distance.

Wrap the button shape in a <selector> (kept inside the ripple so touch
still gets the press ripple) that adds a bright 3dp white stroke on
state_focused.

Closes #209

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
screentinker 2026-07-23 11:34:21 -05:00 committed by GitHub
parent e7483dfc24
commit 11c2890433
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 20 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
android/app/src/main/res/drawable/button_primary.xml
View file

@ -1,10 +1,26 @@
<?xml version="1.0" encoding="utf-8"?>
<!--
Keeps the touch press ripple, and adds a high-contrast white stroke on
state_focused so D-pad navigation on Android TV is visible from across the
room (the bare <ripple> only reacted to state_pressed). See issue #209.
-->
<ripple xmlns:android="http://schemas.android.com/apk/res/android"
android:color="#2563EB">
<item>
<shape android:shape="rectangle">
<solid android:color="#3B82F6" />
<corners android:radius="8dp" />
</shape>
<selector>
<item android:state_focused="true">
<shape android:shape="rectangle">
<solid android:color="#3B82F6" />
<stroke android:width="3dp" android:color="#FFFFFF" />
<corners android:radius="8dp" />
</shape>
</item>
<item>
<shape android:shape="rectangle">
<solid android:color="#3B82F6" />
<corners android:radius="8dp" />
</shape>
</item>
</selector>
</item>
</ripple>