Archive/screentinker
1
0
Fork 0
mirror of https://github.com/screentinker/screentinker.git synced 2026-08-13 13:53:12 -06:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

Fix banner persistence across view switches and modal scroll on open

Browse source 
Co-authored-by: ChrisChrome <28414320+ChrisChrome@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot] 2026-08-10 21:56:03 +00:00 committed by GitHub
parent 4fe2552971
commit 1e278ea373
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 10 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
frontend/css/main.css
View file

@ -1505,6 +1505,7 @@ body {
.sidebar-backdrop.open { display: block; } .sidebar-backdrop.open { display: block; }
.nav-link { min-height: 44px; padding: 10px 14px; } .nav-link { min-height: 44px; padding: 10px 14px; }
.content { margin-left: 0; padding: 16px; padding-top: 68px; } .content { margin-left: 0; padding: 16px; padding-top: 68px; }
#banners { margin-left: 0; }
.page-header { flex-direction: column; gap: 12px; align-items: flex-start; } .page-header { flex-direction: column; gap: 12px; align-items: flex-start; }
.device-grid { grid-template-columns: 1fr; } .device-grid { grid-template-columns: 1fr; }
.content-grid { grid-template-columns: repeat(auto-fill, minmax(150px, 1fr)); } .content-grid { grid-template-columns: repeat(auto-fill, minmax(150px, 1fr)); }

2
frontend/index.html
View file

@ -174,6 +174,8 @@
</div> </div>
</nav> </nav>
<div id="banners" style="margin-left:var(--sidebar-width)"></div>
<main class="content" id="app"> <main class="content" id="app">
<!-- Views rendered here --> <!-- Views rendered here -->
</main> </main>

12
frontend/js/app.js
View file

@ -609,8 +609,8 @@ function updateVerifyBanner(user) {
const unverified = user && user.email_verified === 0 && user.auth_provider === 'local'; const unverified = user && user.email_verified === 0 && user.auth_provider === 'local';
if (!unverified) { if (existing) existing.remove(); return; } if (!unverified) { if (existing) existing.remove(); return; }
if (existing) return; if (existing) return;
const appEl = document.getElementById('app'); const bannersEl = document.getElementById('banners');
if (!appEl || !appEl.parentNode) return; if (!bannersEl) return;
const b = document.createElement('div'); const b = document.createElement('div');
b.id = 'verifyBanner'; b.id = 'verifyBanner';
b.style.cssText = 'background:var(--warning,#f59e0b);color:#1a1200;padding:9px 16px;font-size:13px;display:flex;align-items:center;justify-content:center;gap:12px;flex-wrap:wrap'; b.style.cssText = 'background:var(--warning,#f59e0b);color:#1a1200;padding:9px 16px;font-size:13px;display:flex;align-items:center;justify-content:center;gap:12px;flex-wrap:wrap';
@ -624,7 +624,7 @@ function updateVerifyBanner(user) {
catch { showToast(t('auth.verify_resend_failed'), 'error'); } catch { showToast(t('auth.verify_resend_failed'), 'error'); }
}); });
b.appendChild(btn); b.appendChild(btn);
appEl.prepend(b); bannersEl.appendChild(b);
} }
function updateWidgetSandboxWarningBanner(user) { function updateWidgetSandboxWarningBanner(user) {
@ -632,8 +632,8 @@ function updateWidgetSandboxWarningBanner(user) {
const disabled = !!user?.current_organization?.widget_sandbox_isolation_disabled; const disabled = !!user?.current_organization?.widget_sandbox_isolation_disabled;
if (!disabled) { if (existing) existing.remove(); return; } if (!disabled) { if (existing) existing.remove(); return; }
if (existing) return; if (existing) return;
const appEl = document.getElementById('app'); const bannersEl = document.getElementById('banners');
if (!appEl || !appEl.parentNode) return; if (!bannersEl) return;
const b = document.createElement('div'); const b = document.createElement('div');
b.id = 'widgetSandboxWarningBanner'; b.id = 'widgetSandboxWarningBanner';
b.style.cssText = 'background:var(--danger,#dc2626);color:#fff;padding:10px 16px;font-size:13px;display:flex;align-items:center;justify-content:center;gap:8px;flex-wrap:wrap;font-weight:600'; b.style.cssText = 'background:var(--danger,#dc2626);color:#fff;padding:10px 16px;font-size:13px;display:flex;align-items:center;justify-content:center;gap:8px;flex-wrap:wrap;font-weight:600';
@ -646,7 +646,7 @@ function updateWidgetSandboxWarningBanner(user) {
link.style.cssText = 'color:#fff;text-decoration:underline;font-weight:700'; link.style.cssText = 'color:#fff;text-decoration:underline;font-weight:700';
b.appendChild(text); b.appendChild(text);
b.appendChild(link); b.appendChild(link);
appEl.prepend(b); bannersEl.appendChild(b);
} }
// Initialize // Initialize

2
frontend/js/components/type-to-confirm-modal.js
View file

@ -38,7 +38,7 @@ export function openTypeToConfirmModal(opts = {}) {
const input = overlay.querySelector('#ttcInput'); const input = overlay.querySelector('#ttcInput');
const confirmBtn = overlay.querySelector('#ttcConfirm'); const confirmBtn = overlay.querySelector('#ttcConfirm');
const errorEl = overlay.querySelector('#ttcError'); const errorEl = overlay.querySelector('#ttcError');
input.focus(); input.focus({ preventScroll: true });
const matches = () => input.value.trim() === String(expected); const matches = () => input.value.trim() === String(expected);
input.addEventListener('input', () => { confirmBtn.disabled = !matches(); }); input.addEventListener('input', () => { confirmBtn.disabled = !matches(); });