Archive/screentinker
1
0
Fork 0
mirror of https://github.com/screentinker/screentinker.git synced 2026-08-15 23:03:14 -06:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Return no thumbnailPath when the image thumbnail write fails

Browse source 
deriveMediaMetadata assigned thumbnailPath before sharp wrote the file, so
a failed write (corrupt image, disk error) returned a name for a file that
was never created. Ingest then stored that phantom thumbnail_path and the
dashboard requested it forever as a broken image. Assign only after the
write succeeds; the video branch already nulled its path on failure.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0131RYmVh8ePEhparD3mXBhU
This commit is contained in:
Rob K 2026-08-07 09:30:19 +01:00
parent 16d8295373
commit 3f1c044940
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
server/lib/content-ingest.js
View file

@ -48,12 +48,16 @@ async function deriveMediaMetadata(sourcePath, filepath, mime) {
const metadata = await sharp(sourcePath).metadata(); const metadata = await sharp(sourcePath).metadata();
// #170: honor EXIF orientation so a portrait photo isn't stored as landscape. // #170: honor EXIF orientation so a portrait photo isn't stored as landscape.
({ width, height } = imageDisplayDims(metadata)); ({ width, height } = imageDisplayDims(metadata));
thumbnailPath = `thumb_${filepath}`; // Assign thumbnailPath only AFTER the write succeeds: a sharp failure used to
// return the already-assigned name for a file that was never written, storing a
// phantom thumbnail_path that the UI then requests forever as a broken image.
const thumbName = `thumb_${filepath}`;
await sharp(sourcePath) await sharp(sourcePath)
.rotate() // #170: auto-orient per EXIF (and strip the tag) so the thumbnail matches .rotate() // #170: auto-orient per EXIF (and strip the tag) so the thumbnail matches
.resize(config.thumbnailWidth) .resize(config.thumbnailWidth)
.jpeg({ quality: 70 }) .jpeg({ quality: 70 })
.toFile(path.join(config.contentDir, thumbnailPath)); .toFile(path.join(config.contentDir, thumbName));
thumbnailPath = thumbName;
} else if (mime.startsWith('video/')) { } else if (mime.startsWith('video/')) {
try { try {
const { execFileSync } = require('child_process'); const { execFileSync } = require('child_process');