From 618af0811a0f017da6d577d29d52702557e337fd Mon Sep 17 00:00:00 2001 From: ScreenTinker Date: Tue, 28 Jul 2026 19:52:52 -0500 Subject: [PATCH] Translate the labels that never went through t() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit A title= is a tooltip the user reads and an aria-label is what a screen reader says, but fourteen of them were hardcoded English. They were invisible to the key checks added earlier precisely because they never call t() — so a French user hovering the only route to workspace members read "Manage members", and a German screen reader announced every modal's close button as "Close". The user-visible ones matter most: the workspace switcher's Manage members and Rename, the video wall's rename and remove, and the dashboard's select-for-wall. All are translated into every active locale, along with the close buttons. A test now rejects a capitalised literal in a title or aria-label, since that is the shape this takes and nothing else catches it. Co-Authored-By: Claude Opus 5 (1M context) Claude-Session: https://claude.ai/code/session_01Uaeo9MvzKoyXuN6ZsbhtkL --- frontend/js/components/admin-create-org-modal.js | 2 +- .../js/components/admin-user-workspaces-modal.js | 2 +- frontend/js/components/type-to-confirm-modal.js | 2 +- .../workspace-members-add-user-modal.js | 2 +- .../components/workspace-members-invite-modal.js | 2 +- frontend/js/components/workspace-rename-modal.js | 3 ++- frontend/js/components/workspace-switcher.js | 4 ++-- frontend/js/i18n/de.js | 6 ++++++ frontend/js/i18n/en.js | 6 ++++++ frontend/js/i18n/es.js | 6 ++++++ frontend/js/i18n/fr.js | 6 ++++++ frontend/js/i18n/it.js | 6 ++++++ frontend/js/i18n/pt.js | 6 ++++++ frontend/js/views/dashboard.js | 2 +- frontend/js/views/designer.js | 2 +- frontend/js/views/video-wall.js | 4 ++-- server/test/i18n-keys-exist.test.js | 16 ++++++++++++++++ 17 files changed, 65 insertions(+), 12 deletions(-) diff --git a/frontend/js/components/admin-create-org-modal.js b/frontend/js/components/admin-create-org-modal.js index 65a2467..bce6202 100644 --- a/frontend/js/components/admin-create-org-modal.js +++ b/frontend/js/components/admin-create-org-modal.js @@ -14,7 +14,7 @@ export function openCreateOrgModal(opts = {}) {

${t('admin.create_org.title')}

-
diff --git a/frontend/js/components/type-to-confirm-modal.js b/frontend/js/components/type-to-confirm-modal.js index ef8da1f..94bc9f5 100644 --- a/frontend/js/components/type-to-confirm-modal.js +++ b/frontend/js/components/type-to-confirm-modal.js @@ -13,7 +13,7 @@ export function openTypeToConfirmModal(opts = {}) {

${esc(title || '')}

- - +

${t('designer.ai.settings_desc')}

diff --git a/frontend/js/views/video-wall.js b/frontend/js/views/video-wall.js index fc09e44..316a2e8 100644 --- a/frontend/js/views/video-wall.js +++ b/frontend/js/views/video-wall.js @@ -192,7 +192,7 @@ async function renderWallEditor(container, wallId) {

${esc(wall.name)} - +

@@ -387,7 +387,7 @@ async function renderWallEditor(container, wallId) {
${renderNoteFor(s.device_id) ? `
${esc(renderNoteFor(s.device_id))}
` : ''}
- + ${resizeHandlesHtml()} `; el.querySelector('.wall-screen-remove').addEventListener('click', (ev) => { diff --git a/server/test/i18n-keys-exist.test.js b/server/test/i18n-keys-exist.test.js index 6a65342..711892e 100644 --- a/server/test/i18n-keys-exist.test.js +++ b/server/test/i18n-keys-exist.test.js @@ -114,3 +114,19 @@ test('a tip marker in a view always names a real string', () => { } assert.deepEqual(missing, [], missing.join('\n ')); }); + +test('user-facing labels are translated, not hardcoded English', () => { + // A title= is a tooltip the user reads and an aria-label is what a screen reader says. Both + // were hardcoded English in a dozen places, so a French user hovering the only route to + // workspace members heard "Manage members". They are invisible to the key checks above + // precisely because they never call t(). + const offenders = []; + for (const file of sourceFiles(FRONTEND)) { + const src = fs.readFileSync(file, 'utf8'); + for (const m of src.matchAll(/(aria-label|title)="([A-Z][a-zA-Z ]{3,40})"/g)) { + offenders.push(`${path.relative(FRONTEND, file)}: ${m[1]}="${m[2]}"`); + } + } + assert.deepEqual(offenders, [], + `these ship English regardless of language:\n ${offenders.join('\n ')}`); +});