Archive/screentinker
1
0
Fork 0
mirror of https://github.com/screentinker/screentinker.git synced 2026-06-14 18:22:46 -06:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

fix(sw): stop the admin service worker from breaking video playback

Browse source 
sw-admin.js (scope '/') intercepted every non-API GET with clone+cache+respond.
Video requests are Range requests -> 206 Partial Content, which can't be cached;
cache.put threw and the handler errored ('ServiceWorker encountered an unexpected
error'), so .mp4s never loaded on any page this SW controls - including the web
player at /player, which then thrashed between items.

Now bypass (network-only) non-GET, Range requests, and /uploads//player/api/
socket.io; only cache same-origin 200s. CACHE bumped to v4 so clients pick up the
new SW + drop the stale bucket.
This commit is contained in:
ScreenTinker 2026-06-08 23:08:13 -05:00
parent c1fbe165e7
commit d4f71bbf3a
1 changed files with 28 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

38
frontend/sw-admin.js
View file

@ -4,9 +4,14 @@
// v2 - first network-first version (replaced a cache-first SW that shipped stale JS)
// v3 - force returning clients to drop the old bucket so the "Add user" admin
// button (and any client still on a pre-v2 cache-first SW) lands.
// v4 - stop intercepting media/content/player + range requests. The old handler
// clone+cache+respond'd every non-API request; a video Range request gets a
// 206 (uncacheable) which broke the handler ("ServiceWorker encountered an
// unexpected error"), so videos never loaded on pages this SW controls
// (e.g. the web player, since this SW's scope is '/').
// Changing this string is what makes the browser detect a new SW + run activate,
// which deletes every cache key != CACHE below.
const CACHE = 'rd-admin-v3';
const CACHE = 'rd-admin-v4';
self.addEventListener('install', e => {
e.waitUntil(caches.open(CACHE).then(c => c.addAll([
@ -23,18 +28,31 @@ self.addEventListener('activate', e => {
});
self.addEventListener('fetch', e => {
// Don't intercept API or socket.io traffic - those need to hit the network unmediated.
if (e.request.url.includes('/api/') || e.request.url.includes('/socket.io/')) return;
// Network-first: respect the server's Cache-Control: no-cache + ETag (304s
// stay fast); fall back to cache only when offline. Re-populate the cache
// on every successful fetch so the offline fallback stays current.
const req = e.request;
// Only handle same-origin GET navigations/assets. Everything else hits the
// network unmediated:
// - non-GET: cache.put() rejects on them anyway.
// - Range requests (video seeking): the response is 206 Partial Content, which
// is uncacheable and breaks clone+cache+respond -> "ServiceWorker encountered
// an unexpected error", stalling video playback.
// - /uploads/ (content/media), /player (the web player), /api/, /socket.io/:
// not ours to cache; the player + server set their own cache headers.
if (req.method !== 'GET' || req.headers.has('range')) return;
const url = req.url;
if (url.includes('/api/') || url.includes('/socket.io/') ||
url.includes('/uploads/') || url.includes('/player')) return;
// Network-first: respect the server's Cache-Control: no-cache + ETag (304s stay
// fast); fall back to cache only when offline. Only cache full, same-origin 200s.
e.respondWith(
fetch(e.request)
fetch(req)
.then(resp => {
const copy = resp.clone();
caches.open(CACHE).then(c => c.put(e.request, copy)).catch(() => {});
if (resp && resp.status === 200 && resp.type === 'basic') {
const copy = resp.clone();
caches.open(CACHE).then(c => c.put(req, copy)).catch(() => {});
}
return resp;
})
.catch(() => caches.match(e.request))
.catch(() => caches.match(req))
);
});