Archive/screentinker
1
0
Fork 0
mirror of https://github.com/screentinker/screentinker.git synced 2026-06-17 03:32:32 -06:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #52 from screentinker/fix/migrate-count-addcolumn

Browse source 
fix(db): boot log counts only ADD COLUMN (#37 follow-up)
This commit is contained in:
screentinker 2026-06-09 10:02:43 -05:00 committed by GitHub
parent 7ef3e2eb93 bae70e9154
commit e2460855d9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
server/db/database.js
View file

@ -185,9 +185,14 @@ const migrations = [
// a swallowed failure left users.must_change_password absent -> total auth lockout). // a swallowed failure left users.must_change_password absent -> total auth lockout).
let _migApplied = 0; let _migApplied = 0;
for (const sql of migrations) { for (const sql of migrations) {
// Only a successful ADD COLUMN means a genuinely-new column (it would throw
// "duplicate column" if it already existed). UPDATE/index statements always
// succeed, so they must NOT count toward "new migrations applied" or the boot
// would falsely report work on every healthy start.
const isAddColumn = /alter\s+table\s+\S+\s+add\s+column/i.test(sql);
try { try {
db.exec(sql); db.exec(sql);
_migApplied++; if (isAddColumn) _migApplied++;
} catch (e) { } catch (e) {
if (!/duplicate column name|already exists/i.test(e.message)) { if (!/duplicate column name|already exists/i.test(e.message)) {
console.error(`[migrate] FAILED: ${sql}\n -> ${e.message}`); console.error(`[migrate] FAILED: ${sql}\n -> ${e.message}`);