Archive/screentinker
1
0
Fork 0
mirror of https://github.com/screentinker/screentinker.git synced 2026-05-15 07:32:23 -06:00
Code Issues Actions Packages Projects Releases Wiki Activity

Always show tap overlay on player cold load

Browse source 
Browser autoplay policy is per-document — a previous session's
localStorage flag does not grant the new page autoplay rights. The
'audio previously unlocked, skipping tap overlay' branch was racing
with YouTube's autoplay block, leaving the player stuck on a paused
embed.

Removed the skip-overlay optimization. The existing 5s auto-dismiss
+ muted-connect fallback still handles unattended kiosks, and a real
user only needs to tap once per cold load to get audio.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
ScreenTinker 2026-04-28 14:54:19 -05:00
parent 06ba054898
commit f951d51214
1 changed files with 5 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
server/player/index.html
View file

@ -190,13 +190,11 @@
playCurrentItem(); playCurrentItem();
} }
// If audio was previously unlocked (user tapped in a prior session), skip the overlay // Always show the tap overlay on cold load. Browser autoplay policy is
if (userHasInteracted) { // per-document — a localStorage flag from a prior session does not grant
console.log('Audio previously unlocked, skipping tap overlay'); // audio autoplay to a fresh page. The overlay auto-dismisses after 5s and
unlockAudio(); // connects muted, so unattended kiosks still recover without a human tap.
connect(config.serverUrl); {
} else {
// Show tap-to-start overlay to unlock audio on auto-reconnect
const tapOverlay = document.createElement('div'); const tapOverlay = document.createElement('div');
tapOverlay.style.cssText = 'position:fixed;inset:0;background:#111827;z-index:2000;display:flex;flex-direction:column;align-items:center;justify-content:center;cursor:pointer'; tapOverlay.style.cssText = 'position:fixed;inset:0;background:#111827;z-index:2000;display:flex;flex-direction:column;align-items:center;justify-content:center;cursor:pointer';
tapOverlay.innerHTML = ` tapOverlay.innerHTML = `