3 commits

Author	SHA1	Message	Date
ScreenTinker	1bb24e7604	Choose the SQLite driver at runtime, and ship the FFmpeg licence with the binaries ... TWO CHANGES, together because they touch the same packager hunks. 1. THE DRIVER. The BrightSign package used to be MANUFACTURED. scripts/build-server-zip.sh dropped better-sqlite3 from package.json and then installed db/sqlite-compat.js into node_modules under that name, so every require resolved to the façade. It worked — and it shipped a database layer that no test had ever executed. That is the same shape as the TELEMETRY_COLLECTOR TDZ crash that took production down while 1676 tests and four CI jobs were green: a build-time rewrite cannot be tested by the build that performs it. db/sqlite-driver.js now decides at runtime: the native driver when it loads, the node:sqlite façade otherwise. One artifact, one code path, and — the point — both branches reachable from a test. ST_SQLITE_DRIVER=node runs the entire suite the way a player runs it, and a new CI job does exactly that on Node 24 with --omit=optional so the fallback is reached the same way it is on hardware, not by an env var alone. better-sqlite3 becomes an optionalDependency, so a host with no compiler installs cleanly and falls back rather than failing. preflight-deps stops trying to rebuild a native module on a host that has no toolchain and a working built-in driver — on a player that was a five-minute node-gyp failure ending in a server that never started. Asking for the native driver BY NAME (ST_SQLITE_DRIVER=better-sqlite3) still fails loudly, because a production box that has lost its native module is broken and should say so rather than quietly running something else. ⚠️ NODE 24 IN PRACTICE. node:sqlite is unflagged only from 23.4; on the 22.x line it needs --experimental-sqlite and on 20.x it does not exist. So the code probes rather than comparing versions, the player package pins engines >=24, and the built-in cases skip on the Node 20 CI job rather than failing there. Verified on Node 24, both drivers, full suite: better-sqlite3 1762 pass / 0 fail node:sqlite 1762 pass / 0 fail and the built payload resolves node:sqlite with no better-sqlite3 present at all. 2. THE LICENCE. The ffprobe/ffmpeg binaries added in the previous commit are LGPL 2.1 and statically linked, so the licence text has to travel WITH them — a link on a website is not the copy the licence asks to accompany the work. The packager now copies COPYING.LGPLv2.1 and a build README into bin/, and refuses to build if the licence is missing. legal/third-party.html gains an LGPL section with the written offer required by section 6 for static linking, and the exact configure line. It also drops Sharp, which that page still listed although #263 removed it, and names what actually does the image work now (jimp, @jsquash/webp, @jsquash/avif). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014kfhrUPit5MCqxeTQyqr56	2026-08-18 20:57:05 -05:00
ScreenTinker	9fa69b69f2	brightsign: ship ffprobe/ffmpeg in the payload so they survive updates ... The staging code added in 4a4b9e3 reads bin/<tool>.gz from the install root, with DATA_DIR as a fallback; until now only the fallback was populated, by hand. The payload carries them, so an update refreshes the media tools along with the server. PAYLOAD ONLY. The boot zip is read by the OS's own zip reader before anything else runs, and a 73MB one failed outright with "ZipArchive error" — it is ~64KB and stays that way. Stored rather than compressed (the archive is -0 throughout) because they are gzipped already: 3.2MB in the package against 6.7MB of tmpfs once unpacked. They live in brightsign/media-tools/ and are excluded from the wholesale brightsign/ staging, or the package would carry both copies. A missing file is a hard error, not a warning: both are tracked, so absence means someone removed them, and the symptom would otherwise be a player that silently stops making video thumbnails. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014kfhrUPit5MCqxeTQyqr56	2026-08-18 20:21:49 -05:00
screentinker	9a1a82a100	Run the ScreenTinker server on the player it serves (#288) ... * Make a BrightSign say what it is running, and what it is plugged into A panel on a wall could not answer three questions an operator asks first: which version am I, which page am I running, and which screen is that. All three had answers already travelling over the socket; nothing was reading them. VERSION. device_info.app_version was the literal '1.1.0-web' for every web player, BrightSign included — the same string as PLAYER_VERSION, which already travels separately as client_version. So the column carried no information at all: a panel provisioned this morning and one running a year-old host reported identically. app_version is now the ON-DEVICE host package, the artifact OTA replaces and the only one here that can be stale, and PLAYER_VERSION is stamped at serve time from VERSION rather than being a constant nobody bumped for the whole 1.x line. No '-web' suffix: client_version is only compared for equality today, but X.Y.Z-web is a semver PRERELEASE that sorts BELOW X.Y.Z, and this project has been bitten by exactly that before. The host version arrives asynchronously and can land after the page registers, so register sends what it has and the heartbeat corrects the record — which also catches the version changing under a live page, which is what a self-update is. THE CARD SHOWED FOR NOBODY. The Info tab's version card sat inside the block gated on android_version && !startsWith('Web/'). A BrightSign registers as "Web/<ua>", so the panel that most needed a version never displayed one. THE PAD THAT COULD NOT BE CLICKED. System View was gated on tier === 2. tier is an Android device-owner concept, NOT NULL DEFAULT 0, written only by the APK — so a BrightSign or Tizen panel sat at 0 forever and rendered HOME, BACK, POWER, the D-pad and OK permanently pointer-events:none, for keys those players genuinely handle. Greying an Android gate over a working control is the "button that cannot work" the capability system exists to prevent, inverted. Only Recents (KEYCODE_APP_SWITCH) and Settings are truly Android-only; those are now the only things hidden. THE PACKAGE POINTED AT THE WRONG SERVER. autorun.zip carried the committed default, so a player self-updating from alpha or a self-hosted box was handed a config pointing at screentinker.com — which surfaces as a pairing bug, miles from the packaging code that caused it. It is now stamped with the URL it was fetched from. The bytes therefore vary per origin, so the cache is keyed by origin and BOTH routes derive it identically: the manifest checksum and the served bytes must come from one buffer or every player downloads, fails verification and retries forever. EDID. getEdidIdentity() answers seven questions and cannot answer any others — manufacturer, EDID version, physical size, gamma and the mode lists exist only in the raw block, which getEdid() returns as 2048 bytes. The player ships those on the register (identity, not a reading: it changes when someone swaps the screen) and the SERVER parses them. That split is the point: a new field becomes a server deploy instead of a bridge update behind a 4h CDN plus an OTA for the host. Verified against real hardware — an XT245 with a CX101 decodes to RTK / 0x1010 / serial 1 / 2020w26 / 22x13cm, preferred 1920x1200@62, matching the player's own DWS field for field. The odd-looking 62 is right: 168.5MHz over 2200 x 1245 is 61.5Hz, and rounding it to a nicer 60 would contradict the panel. Also corrects two comments that had outgrown their reasoning: the BrightSign capability baseline still explained its exclusions with "a canvas cannot read the video plane", which native capture made obsolete, and player-parity.md claimed the bridge is "always current" when a zone-wide Cloudflare Browser Cache TTL had been rewriting its no-cache to max-age=14400 for months. Every new guard is mutation-tested — the fix was reverted in the source and each test confirmed to fail. 1676 -> 1714 tests, all green. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014kfhrUPit5MCqxeTQyqr56 * Run the ScreenTinker server on the player it serves A BrightSign XT245 now downloads, installs and runs the server itself, with the display showing what it is doing until it is up. WHY IT NEEDED A NEW SHAPE BrightSignOS cannot open a large autorun.zip. The 73MB build failed at boot with "ZipArchive error at line 91", and the OS renamed it autorun.zip_invalid - which is how a device that had already unpacked once came back up with no autorun at all. The identical package cut to 32KB and five files boots fine; paths (182 chars) and depth (8) are unremarkable, so the limit is in the boot-time reader, not the archive. BrightSign's own notes acknowledge package size as a problem and point at webpack; that route needs the dynamic requires in scripts/ removed first, so instead autorun.zip carries only what starts the process and the payload arrives over HTTP into a Node that has no such limit. The payload can also be updated without re-provisioning the device. WHY roNodeJs AND NOT THE WIDGET The first version ran the server inside an roHtmlWidget with nodejs_enabled. That is a Node context inside an Electron renderer, and it is not Node. Four separate boot failures came out of it, each invisible to a local test because a local test runs on real Node: - shebangs are not stripped, so any `#!/usr/bin/env node` file dies with "Failed to construct 'ContextifyScript': Invalid or unexpected token". Note it names no token - "#" is not one. An ESM file compiled as CJS says "Unexpected token 'export'" instead, which is how the two are told apart. - require() of an ESM-only package is unsupported, which plain Node 24 handles. uuid 14 is ESM-only and 21 files import it. - setInterval is the DOM's and returns a NUMBER, so setInterval(...).unref() throws. Two call sites were unguarded; sixteen more were written defensively and had been silently not unreffing. - worker_threads cannot create a thread at all. BrightSign's dev-cookbook is explicit: roNodeJs "for long running processes like ... running a web server", roHtmlWidget "for browser-based apps". Their cra-template examples do exactly this - server in roNodeJs, widget pointed at localhost. It also fixes the lifecycle problem that was the original argument against a server on this hardware: in a widget the server dies with the page, taking an open SQLite WAL with it. The shims for the first three are kept in the packager for now rather than removed in the same change that moves the container, so that if something breaks it is the move and not four simultaneous removals. CHANGES THAT ARE NOT BRIGHTSIGN-SPECIFIC db/database.js, routes/status.js fs.copyFileSync does not merely copy bytes: it fchmods the destination to match the source. exFAT has no permission bits, so the pre-migration snapshot failed with EPERM and the failure path called process.exit(1) - which inside a widget also killed the page, leaving a black screen and no diagnostic. The guard was right; the copy was wrong. lib/fsutil.js copies without touching mode. db/wal-checkpointer.js the module already degraded correctly when its worker died or could not be respawned, but the FIRST spawn was not wrapped, so a host that cannot make threads lost the whole server rather than falling back to inline autocheckpoint. db/sqlite-compat.js a better-sqlite3 facade over node:sqlite. With it the bundle contains no native code at all, which is what lets an x86_64 laptop build a package for an aarch64 player. 1719/1719 tests pass on Node 24 through this shim. The packager refuses to build if a source file is untracked (git ls-files decides what ships, and lib/fsutil.js reached a player without shipping alongside the code that required it), if any .node binary is present, if a shebang survives, or if a database, upload, cert or .env is staged - the first build of this package swept up a real 33MB database and 105MB of uploads. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014kfhrUPit5MCqxeTQyqr56 --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com> Co-authored-by: Dan Walters <dan.walters@bytetinker.net>	2026-08-18 15:16:09 -05:00