2 commits

Author	SHA1	Message	Date
screentinker	76f072bf4b	fix(tizen): decode-gated image double-buffer to kill the black flash between stills [#187] (#193) ... The Tizen .wgt player black-flashed between IMAGE items on slow decode HW (Samsung OM55B / SSSP). Root cause: playCurrent() called clearStage() before renderImage() set img.src, so the stage was empty (black) until the new image decoded. Images had no decode-gated double-buffer — video gained one in #167 (938a43a), which made the always-present image flash conspicuous by contrast. renderImage has been byte-identical since the first Tizen commit, so there was nothing to revert; the buffer had to be ADDED, mirroring the video path. - preloadImage()/_takePreloadImage()/_releasePreloadImage(): one-ahead, image-only decode-gated buffer modeled on preloadVideo()/_takePreload(). Detached <img>, src set, warmed via HTMLImageElement.decode() (feature- detected — onload/complete fallback for Tizen 5.0 / SSSP6). Warmed when the current image begins its dwell and from the group-sync boundary tick. - renderImage now SWAPS: take the pre-decoded <img> (or decode a fresh one) and only THEN clearStage()+append, in one synchronous block — the compositor never sees an empty stage. Never clear-then-load on the image path. - Scoped to images only: playCurrent() skips the up-front clearStage() solely for image targets (same branch order as the dispatch); video/youtube/widget keep their pre-dispatch clear untouched. onerror and decode() rejection route to skipSoon(); stale-index guard blocks mounting a stale decode over the current item after next()/gotoIndex/load(); one-ahead with stale release on index move, load(), stop(), and group-sync exit. #A1 single-item heal intact. Tests: - server/test/tizen-image-blackflash.test.js (new, 4/4): loads the real player.js in a vm context with a test-controllable decode() Promise and proves the invariant — across image->image the #stage is NEVER without a mounted <img> (old element held until the new image's decode()/onload resolves, then swap). Covers decode() supported, decode() absent (onload fallback), and broken-image (decode-reject / onerror) -> skipSoon. Proven to VIOLATE on the old clear-then-load ordering and HOLD on the fix. - server/test/pip-overlay.test.js: the decode-gate makes image mount async, which broke its older shim (no decode()/onload/complete). Teach the shim element complete/naturalWidth so renderImage takes its synchronous complete-fallback branch and mounts. Test-only. Full server suite 486/486. node -c clean. Headless proves the DOM ordering invariant (the flash's precondition); final black-frame sign-off needs a real OM55B panel (manual steps in the test-file header). Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>	2026-07-15 18:29:39 -05:00
screentinker	965920cd17	PiP overlay MVP: push image/web overlays to a device or group (#109) (#127) ... * PiP overlay MVP: push image/web overlays to a device or group (#109) Implements the #109 MVP from docs proposal: a floating overlay PUSHED to a device or group in real time, rendered above the playlist without disturbing it. Scope is the MVP only — video/RTSP, MQTT, offline-queue, and the priority/stacking system are deferred to follow-up PRs as the proposal specifies. Protocol (/device socket, player-agnostic): - device:pip-show { pip_id, type:image|web, uri, position, width, height, duration, title?, title_color?, background_color?, opacity?, border_radius?, close_button? } - device:pip-clear { pip_id? } The player fetches uri itself (same trust model as remote_url content; server never proxies). type:web is full-trust by design, hence the 'full' token scope. Server (server/routes/pip.js, new; mounted in config/api-surface.js PUBLIC_ROUTERS): - POST /api/pip and POST /api/pip/clear + DELETE /api/pip, all requireScope('full'). - Resolves device_id to a device OR a group, expands a group to members, and emits per-device — reusing the group command route's room-size online check and {device_id, name, status: sent|offline} result shape. Generates pip_id. - Validates type/position allowlists, uri http(s), numeric bounds on width/height/duration/opacity/border_radius, colors via the existing VALID_COLOR (#RRGGBB; transparency is the separate opacity field). - Workspace-isolated: every target query is scoped to req.workspaceId, so a token bound to workspace A can't address workspace B (404). Offline devices are reported, never queued (PiP is ephemeral). Player overlay layer (Tizen; tizen/js/pip-overlay.js, new): - A #pip sibling ABOVE #stage that PlaylistPlayer/ZoneRenderer never touch. - applyOrientation now applies the SAME transform to #pip as #stage, so corner positions track the visible CONTENT in all four orientations. - image -> <img>, web -> <iframe> (muted by default: empty allow= denies autoplay), sized/positioned/styled per payload, optional title bar. - Single overlay slot, last-show-wins; duration timer (0 = until cleared); pip-clear (id-aware) or timer tears down; teardown wrapped so a malformed payload can't wedge the layer. Reports show/clear over device:log (tag 'pip'). Dashboard: a minimal "Send overlay" / "Clear overlay" tester on the device-detail controls (device/group via the open device, type, uri, position, duration), calling POST /api/pip through the api helper. Tests (server suite green, 161/161): - api.test.js: PiP tier — authz (read/write 403, full passes), workspace isolation (wsA token -> wsB device 404), payload validation, device + group targeting, clear; plus the PUBLIC_ROUTERS snapshot-firewall updated for /api/pip. - pip-overlay.test.js: loads the real player.js + pip-overlay.js in a vm with a DOM shim; proves the overlay shows, auto-dismisses on the duration timer, and never changes the playlist signature / touches #stage; web->iframe, last-show-wins, id-aware clear, malformed-payload safety. Not in this PR (intentional): - Android player overlay — fast-follow. Protocol + server are player-agnostic; the Android layer (an overlay View above the player, orientation-matched to MainActivity's rootView rotation) is the same shape and lands next. - OpenAPI docs for POST /api/pip — the contract test's scope heuristic only treats 'command' paths as full-scope, so documenting a full-scope non-command route there needs that heuristic extended first; deferred with the docs item (proposal §8.6). - video/rtsp types, MQTT, offline queue-on-reconnect, priority/stacking, arbitrary (x,y)/selector positioning (proposal §6). Refs #109 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * PiP overlay: add Android + web players (#109) Extends the #109 PiP MVP to the other two players so the protocol (device:pip-show / device:pip-clear) is honored fleet-wide, not just on Tizen. No server/protocol changes — the route and socket messages are player-agnostic; these are the two missing surfaces. Web player (server/player/index.html): - New #pipContainer layer above #playerContainer, pointer-transparent, that the playlist render never touches. The same orientation transform is applied to it as to #playerContainer (extended to also reset width/height on landscape so a portrait->landscape switch realigns), so corner positions track the visible content. - Inline PiP logic mirroring tizen/js/pip-overlay.js: image -> <img>, web -> <iframe> (muted by default via empty allow=), position/size/bg/opacity/radius/title, single slot last-show-wins, duration timer (0 = until cleared), id-aware clear, wrapped teardown. - device:pip-show/clear handlers; reports show/clear over device:log (tag "pip"). Android player: - activity_main.xml: a pipLayout FrameLayout as the LAST child of rootLayout — it draws above the content AND inherits rootView's orientation rotation/translation, so corner positioning is orientation-matched for free. - PipOverlay.kt (new): builds the overlay box into pipLayout. image -> ImageView (decoded off-thread via ImageLoader, dropped if torn down mid-decode); web -> WebView with mediaPlaybackRequiresUserGesture=true (mute-by-default). Gravity-based corner/center placement with a 4% inset, GradientDrawable bg + corner radius, alpha=opacity, optional title bar. Single slot last-show-wins; duration timer; id-aware clear; teardown wrapped and also run on activity destroy (WebView cleanup). - WebSocketService: onPipShow/onPipClear callbacks + safeOn handlers posted to the main thread (they build Views) + a sendLog(tag, level, message) emitter for device:log. - MainActivity: instantiate PipOverlay (log -> wsService.sendLog("pip", ...)), wire the callbacks, tear down on destroy. Verified: Android assembleDebug builds clean; web player inline JS parses; server suite still 161/161 (no server changes this commit). Not yet validated on real hardware — four-orientation corner positioning mirrors the player container/rootView transform but should be eyeballed on a panel. Refs #109 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>	2026-06-18 14:54:44 -05:00