mirror of
https://github.com/screentinker/screentinker.git
synced 2026-08-18 16:13:51 -06:00
0511e9b5bb
Follow-up to #285. Three corrections that rode in with the Japanese locale. 1. The ja key-parity check failed the build whenever en.js had a key ja.js lacked. i18n.js lookup() is already `registry[lang]?.[key] ?? fallback[key] ?? key`, so an untranslated string renders in English and nothing is broken by a gap - the only effect was that adding any English string blocked CI until a Japanese translation existed. It also singled out one locale; es/fr/de/pt/hi/it were never held to it, and hi.js is a deliberate skeleton whose own header explains that every key falls back to English on purpose. Replaced with two checks over EVERY locale: a locale may not define a key that English does not (dead weight after a rename, and fixable by whoever touched the file, whatever language they speak), and coverage is printed rather than gated. Help tips still have to exist everywhere - that test is unchanged and still fails. Current coverage: ja 100%, es 65.5%, fr/de/pt 63.7%, it 59.5%, hi 0%. 2. Applying the strict half to all locales immediately found add_display.smart_tv_note living in fr, pt, it and de but not in en.js and referenced by no view - a string dropped from English that left four translations behind. Removed. 3. The new timezone test restored process.env.TZ by assigning the saved value back. When TZ was not set to begin with - which is the case in CI - that assigns undefined, which writes the STRING "undefined"; Node cannot parse it and silently falls back to UTC for the rest of the process. Every test after it in that file is date arithmetic. It now deletes the key when it was previously unset. 4. package-lock.json removed from .gitignore. server/package-lock.json is tracked, so the rule was inert, but it would silently prevent a future lockfile and works against the SBOM and reproducible-install setup added in #282. Claude-Session: https://claude.ai/code/session_014kfhrUPit5MCqxeTQyqr56 Co-authored-by: Dan Walters <dan.walters@bytetinker.net> Co-authored-by: Claude Opus 5 <noreply@anthropic.com> |
||
|---|---|---|
| .. | ||
| config | ||
| db | ||
| lib | ||
| middleware | ||
| player | ||
| routes | ||
| scripts | ||
| services | ||
| test | ||
| ws | ||
| .gitignore | ||
| config.js | ||
| node_modules | ||
| package-lock.json | ||
| package.json | ||
| server.js | ||
| smoke-ui.js | ||
| version.js | ||