mirror of
https://github.com/screentinker/screentinker.git
synced 2026-08-14 06:16:20 -06:00
0df7f58b26
Follow-up to #233, which made the upload ceiling configurable — the right call, 500MB is genuinely too low for video. An environment variable is a string, so the value reached multer's limits.fileSize as text where a number is expected. That survives some comparisons through coercion and misbehaves in others, which is the worst kind of bug to find later; the line directly above it already used parseInt for the same reason. It is parsed properly now, and a suffix is accepted — someone raising a limit for video is choosing "about 2GB", and 2147483648 is easy to mistype by a factor of ten. An unparseable value falls back to the default rather than becoming NaN or zero. Either would reject every upload on the instance, from a typo in an env file, with nothing on screen to explain it. The documentation matters as much as the code here. MAX_FILE_SIZE is the LAST limit in the chain: nginx caps the request body with client_max_body_size and returns 413 before the app is reached — our own deployment sets 500M — and Cloudflare caps uploads per plan at the edge. Raising the variable alone often changes nothing, so the README now says so, with the nginx directive and a note that an upload failing with nothing in the server log never reached the server. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uaeo9MvzKoyXuN6ZsbhtkL
38 lines
1.6 KiB
JavaScript
38 lines
1.6 KiB
JavaScript
'use strict';
|
|
|
|
// Parse a human-written size into bytes.
|
|
//
|
|
// Environment variables are always STRINGS. `process.env.MAX_FILE_SIZE || default` therefore
|
|
// yields the string "2000000000", which then travels into multer's limits.fileSize where a
|
|
// number is expected — it happens to survive some comparisons through coercion and misbehaves
|
|
// in others, which is the worst kind of bug to chase.
|
|
//
|
|
// A plain byte count is also unfriendly for this particular setting: the person raising an
|
|
// upload limit for video is choosing "about 2GB", and 2147483648 is easy to mistype by a
|
|
// factor of ten. So a suffix is accepted as well.
|
|
//
|
|
// Deliberately strict: anything unparseable returns the fallback rather than 0 or NaN. A typo
|
|
// in an env var must not silently become "reject every upload", which is what a NaN limit or a
|
|
// zero would do.
|
|
|
|
const UNITS = { b: 1, kb: 1024, mb: 1024 ** 2, gb: 1024 ** 3, tb: 1024 ** 4 };
|
|
|
|
function parseSize(value, fallback) {
|
|
if (value == null || value === '') return fallback;
|
|
if (typeof value === 'number') return Number.isFinite(value) && value > 0 ? Math.floor(value) : fallback;
|
|
|
|
const raw = String(value).trim().toLowerCase().replace(/\s+/g, '');
|
|
// Bare digits are bytes, which is what the variable meant before suffixes were understood.
|
|
if (/^\d+$/.test(raw)) {
|
|
const n = Number(raw);
|
|
return n > 0 ? n : fallback;
|
|
}
|
|
const m = raw.match(/^(\d+(?:\.\d+)?)(b|kb|mb|gb|tb)$/);
|
|
if (!m) return fallback;
|
|
const n = parseFloat(m[1]);
|
|
if (!Number.isFinite(n) || n <= 0) return fallback;
|
|
return Math.floor(n * UNITS[m[2]]);
|
|
}
|
|
|
|
module.exports = { parseSize };
|