mirror of
https://github.com/screentinker/screentinker.git
synced 2026-08-14 14:23:14 -06:00
6471c503ab
Adding a 32s video gave it the flat 10s default, so it was cut off mid-play unless the operator looked up the runtime and typed it — per item, every time. The content row already carries the probed duration; it now becomes the default. The rule lives in one place (lib/item-duration.js) because the operator sees one product, not six insert paths: playlist add, assign-to-display, group assign, agency portal, content-only schedule, and the public API all share it. Only the playlist route defaulted before, and it stored the raw probe (31.7) which the Android player's optInt read silently truncated back to 31. Explicit values always win. Content with no trustworthy duration (image, widget, YouTube, remote URL, failed probe) keeps the 10s default, and a duration that is 0/negative/NaN or absurd (> 12h, i.e. a broken probe) falls back rather than reaching a device — a 0 makes the players schedule a 0ms advance, which self-loops and black-screens the TV. Dashboard: the add-item picker shows a clip's length, the assign-to-display modal pre-fills the duration field from the selected clip (never overwriting a value the operator typed), and onboarding stops hardcoding 10 on the first assignment. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uaeo9MvzKoyXuN6ZsbhtkL
40 lines
2.1 KiB
JavaScript
40 lines
2.1 KiB
JavaScript
'use strict';
|
|
|
|
// #237: a video added to a playlist got the flat 10s default, so a 32s clip was cut off at
|
|
// 10s unless the operator looked up the runtime and typed it in — per item, every time. The
|
|
// content row already carries the probed length, so that becomes the default. Shared by
|
|
// every playlist_items insert path (dashboard, device assign, group assign, agency portal,
|
|
// schedules, public API) because the operator sees one product, not six routes.
|
|
|
|
const DEFAULT_ITEM_DURATION = 10;
|
|
|
|
// A probe that reports longer than this is a broken container (streams and truncated files
|
|
// report absurd or near-infinite lengths), not a clip anyone means to schedule — honoring it
|
|
// would park a display on one item for days with no obvious cause. 12h.
|
|
const MAX_CONTENT_DURATION = 43200;
|
|
|
|
// The content's own length, or null when there isn't a trustworthy one: images, widgets,
|
|
// YouTube and remote-URL rows carry no duration, and a failed ffprobe leaves null/0. Rounded
|
|
// UP so a 31.7s clip gets 32 and not a 31 that clips the tail; whole seconds because the
|
|
// Android player reads duration_sec with optInt (a fractional value silently truncates) and
|
|
// an operator expects to see a round number in the duration box.
|
|
function contentDefaultDuration(content) {
|
|
const n = Number(content && content.duration_sec);
|
|
if (!Number.isFinite(n) || n <= 0 || n > MAX_CONTENT_DURATION) return null;
|
|
return Math.max(1, Math.ceil(n));
|
|
}
|
|
|
|
// The duration to STORE on a new playlist_item. An explicit operator value always wins; the
|
|
// content's own length is only a default for when none was given.
|
|
//
|
|
// Anything that isn't a usable number falls back rather than reaching the DB: a duration of
|
|
// 0 (or NaN, from a client that sent a string) makes the players schedule a 0ms advance,
|
|
// which self-loops and black-screens the TV (#widget zero-duration loop).
|
|
function resolveItemDuration(requested, content) {
|
|
const n = Number(requested);
|
|
if (Number.isFinite(n) && n >= 1) return Math.floor(n);
|
|
return contentDefaultDuration(content) ?? DEFAULT_ITEM_DURATION;
|
|
}
|
|
|
|
module.exports = { resolveItemDuration, contentDefaultDuration, DEFAULT_ITEM_DURATION, MAX_CONTENT_DURATION };
|