From 85e4bce407ad9c7ef2847ddc3c9b489418afd2c2 Mon Sep 17 00:00:00 2001
From: steve-lad <72376554+steve-lad@users.noreply.github.com>
Date: Sun, 30 May 2021 14:27:45 +0200
Subject: [PATCH] Simplify tests

Use Isset instaed of empty twice
---
 conf/Sccp.class.php.v433 | 22 ++++------------------
 1 file changed, 4 insertions(+), 18 deletions(-)

diff --git a/conf/Sccp.class.php.v433 b/conf/Sccp.class.php.v433
index 96e033f..1a12796 100644
--- a/conf/Sccp.class.php.v433
+++ b/conf/Sccp.class.php.v433
@@ -93,27 +93,13 @@ class Sccp extends \FreePBX\modules\Core\Driver {
         $sqlCol = 'name';
         $sqlVal = "\'{$id}\'";
         foreach($this->data_fld as $key => $val) {
-            if (!empty($settings[$val]) ) {
-                if (!empty($settings[$val]['value'])){
-                    $sqlCol .= ", {$key}";
-                    $sqlVal .= ", \' {$settings[$val]['value']} \'";
-                }
+            if (isset($settings[$val]['value'])){
+                $sqlCol .= ", {$key}";
+                $sqlVal .= ", \' {$settings[$val]['value']} \'";
             }
         }
         $sql = "REPLACE INTO sccpline ( {$sqlCol} ) VALUES ( {$sqlVal} );";
-        /*
-        $sql = 'REPLACE INTO sccpline (name';
-        $sqlv = 'values ("'.$id.'"';
-        foreach($this->data_fld as $key => $val) {
-            if (!empty($settings[$val]) ) {
-                if (!empty($settings[$val]['value'])){
-                    $sql .= ', '.$key;
-                    $sqlv .= ", '".$settings[$val]['value']."' ";
-                }
-            }
-        }
-        $sql .= ") ".$sqlv.");";
-        */
+
         $sth = $this->database->prepare($sql);
         $sth->execute();
         return true;