Commit graph

231 commits

Author SHA1 Message Date
stevenA 048077fce8 Update SIP device Handling & Fix Issue#53
Fix Issue #53
Consolidate forms to facilitate maintenance, reduce code, and apply changes to SIP handling introduce for sccp
Delete form.addsdevice.php
Delete form.sbuttons.php
Delete sipconfigs class and move db functions to dbinterface class, and other function to helperfunctions
create new field type for SIP line
update 9951 buttons count in installer
simplify segregation of sip and sccp requests
2022-01-06 15:00:24 +01:00
stevenA 1f73ade196 Fix Issue #54
Do not try to write SEP file if no line defined. Save settings and warn user via toast
Fix feedback to ajax by separately submitting data before return
Fix freepbx overwriting data and causing fail, by separating json into two blocks and only parsing the first
Fix return to tab on save (set location hash) when tabs changed in settings
Fix return to calling page on save when device updated
2022-01-04 14:41:43 +01:00
stevenA 198b3fffa8 Update save SIP device
Fail if no valid FreePbx sip bindings available

Fix SIP display issue

Correct line protocol selection
2022-01-02 13:06:41 +01:00
stevenA c473c62ada Fix issue #47 - Defaults toggling with repeated saves
Remove unused group from server.settings.php
Correct testing for use of system defaults
Correct application of system defaults
ToDo:Numeric values are not being saved, or do not revert to defaults when button clicked
2021-12-30 15:22:20 +01:00
stevenA a395120fac Change version number in Sccp Info
Use module.xml to get version
2021-12-28 10:56:49 +01:00
steve-lad a2217e6e37 Fix issue #39
Get masterFilesList at install direct from Provisioner. If not available, install a copy from the module
2021-12-27 11:09:42 +01:00
steve-lad 8f6c7be74e Optimise handle submit
Change order of treatment of returned data
Handle db calls outside of loops
Optimise parsing
2021-08-15 13:07:36 +02:00
steve-lad 90729f74aa Update for compatibility with PHP 7.4
PHP 7.4 gives warnings that are handled as exceptions
2021-08-10 07:08:10 +02:00
steve-lad 0f352eeb59 Fix addition of new device when not in db
Partial fix for issue#29

Populate available fields
Optimise code
2021-08-07 11:03:33 +02:00
steve-lad 14215b64ca Finalise chan-sccp build info 2021-08-06 08:42:39 +02:00
steve-lad 6567923ff1 Add chan-sccp build info to Sccp Info 2021-08-06 08:24:53 +02:00
steve-lad 6775b6686b Simplify getPhoneGrid 2021-08-01 14:54:17 +02:00
steve-lad ab7b295b87 switch basedir path source
Use $amp_conf['AMPWEBROOT'] instead of $_SERVER['DOCUMENT_ROOT'] as at least in one case the latter appears to be empty
2021-07-31 17:07:37 +02:00
steve-lad 49fd6a5c91
Merge pull request #30 from chan-sccp/issue/28
Device SEP ID
2021-07-30 11:54:02 +02:00
steve-lad 60f7d74cf4 Update Sccp Info 2021-07-30 09:12:51 +02:00
steve-lad d432ff7a05 Ensure that addons cannot be added in edit on devices that do not have addons 2021-07-30 07:27:31 +02:00
steve-lad d43570b471 Enable addition of sidecars to an existing device 2021-07-29 13:50:31 +02:00
steve-lad b753482898 Correct defaults after db schema change 2021-07-29 08:43:40 +02:00
steve-lad 4e9dcb09f3 Fix return link if default button changed 2021-07-25 16:03:02 +02:00
Diederik de Groot a1e52d01a4 Rename Device SEP ID to Device ID
Use "XX:XX:XX:XX:XX:XX" as the default display format for device MAC Address
References #28
2021-07-25 12:27:05 +00:00
steve-lad 26f750296a Fix various issues with buttons
Add choice of default line on add device
Partially fix buttoncount (will not work if default device is selected)
Correct database save logic for buttons - triggers should be OK but more verification needed
Fix various save issues where defaults not correctly set
Delete default buttons when deleting line to avoid orphans
2021-07-25 13:42:42 +02:00
steve-lad 75858d7cc1 Optimise and add error handling to getFilesFromProvisioner 2021-07-24 09:31:30 +02:00
steve-lad 4151b4fdae Restructure languages and locales management
Base off of provision file structure
Store netlang and devlang
Stop usage of extconfig ->sccplang
2021-07-23 12:14:46 +02:00
steve-lad 215cacae41 Get Country tones with locales
Get country files with locales
WIP incompatibility between provision, its rewrite rules and the file structure
WIP - need to clean up get files from provisioner
2021-07-21 16:44:23 +02:00
steve-lad 3475efc2c6 Database request modifications and page improvements
Add device to extensions page - permits to see unassigned  lines and shared lines easily
Reformat status to centred
change 'replace' in sccp class to only 'insert on duplicate key' (UPSET equivalent)
Change request in phoneGrid to left join to show all lines, even unassigned to a device
2021-07-21 11:30:50 +02:00
steve-lad a4aa4eb03b Simplify db queries and change alignment 2021-07-21 08:57:43 +02:00
steve-lad 97c1395eb1 Fix Fill Phone status column
Add db query to include mac to allow join with ami active device data
Change output fields
2021-07-20 18:03:44 +02:00
steve-lad 477eb69146 Fix phonepersonalisation
Set expected numeric value for phonepersonalization
WIP fix - adv.ini
2021-07-20 12:53:29 +02:00
steve-lad 2898f5e3c9 Fix bug codecs storage
codecs were stored as a ',' separated list while chan-sccp expects a ';' separated list
Correct all existing db values when running installer
make sure that disallow is not unset in installer (set to all)
make sure that disallow is not empty
correct help text
2021-07-20 09:32:01 +02:00
steve-lad b3b3858965 standardise get ext file modal and add via include
Create standard modal for insertion via include in firmcreate class and adserver view
2021-07-19 08:04:12 +02:00
steve-lad d7fd77dfe8 Get locales from provisioner
Add progress bar and xhr handler
2021-07-18 11:30:19 +02:00
steve-lad 1b32e0977e Optimise locale (language) management
Optimise function calls
Use array functions instead of loops
findInstalledlangs is currently called by the construct - as this is called frequently, maximise its efficiency
2021-07-15 12:12:07 +02:00
steve-lad ef77bce159 Add retrieve device files 2021-07-14 13:10:15 +02:00
steve-lad 651f3adb44 Finalise TFTP Mapping treatment
User no longer can select on or pro: If remapping is enabled and rules are set, then must use pro or phones will not find files
Otherwise is Off (flat directory)
2021-07-12 12:26:56 +02:00
steve-lad 5a184ededb Integrate Provision functionality into Sccp_Manager
Create required directory structure
Check if mapping support is enabled
Check if mapping rules are defined
Change options available based on above
Create index.cnf and sccpManagerRewrite.rules
2021-07-11 16:52:24 +02:00
steve-lad 248abe6cb7 Clean up and correct missing save settings
Remove unnecessary method from formcreate
Correct indentation in formcreate
Remove debug code in Sccp.class
correct logic for updating TFTP mode
2021-07-10 17:51:55 +02:00
steve-lad 2a98d8cfdb Override chan-sccp default context 2021-07-10 12:17:46 +02:00
steve-lad 71fef35ebd Finalise FormShowSysDefs
Remove debug conditionals in Sccp_manager
Pass missing arguments for tftpLang
Remove unused items from sccpgeneral.xml
2021-07-10 10:45:42 +02:00
steve-lad ce115dab8b Create formCreate class
Move anonymous class frpm formShowSysDefs to own class
2021-07-10 09:03:06 +02:00
steve-lad d966bfa303 Minor typo corrections and add defaults button to device add/edit 2021-07-09 14:06:25 +02:00
steve-lad 6429b6add9 Finalise Codec Management
Add video codec treatment
Correct missing defaults
Simplify defaults in Sccp.class
2021-07-08 08:56:42 +02:00
steve-lad 945e77f9bc Simplify getCodecs by using array functions 2021-07-06 17:18:17 +02:00
steve-lad f929267910 Provide mechanism to reset codecs to system defaults
Unchecking all codecs will return to chan-sccp defaults
Document this behaviour
Remove various debug code
2021-07-06 16:12:25 +02:00
steve-lad 2e5028f438 Finalise Codecs tab for site defaults
Partially revert changes to sccpvalues keys
Remove obsolete code
Improve help and set as open by default
Move getMyConfig to AjaxHelper as only used there
2021-07-06 15:22:12 +02:00
steve-lad 44e0846761 Update server.codec.php
Add Recommendation for disallow
2021-07-06 08:30:38 +02:00
steve-lad a6a9850a3c rewrite codec methods to be more compliant with chan-sccp
Update db Fields for defaults
Update save logic
WIP update save defaults Field  in sccpline
2021-07-05 17:08:01 +02:00
steve-lad a493165153 Insert missing </div> at end of SL type
</div> was commented out
Change sccpdevice type to IE ( using a list suggests changes are legitimate. While true, they are not recommended, so now user must know exactly what to enter.
2021-07-05 11:02:52 +02:00
steve-lad 2809b0796e Simplify List Button Presentation
Standardise method for all SL Types
WIP - unused method needs to be removed after full testing
2021-07-05 10:27:26 +02:00
steve-lad 503f227b98 Convert formShowSysDefs to anonymous class
Allows use of methods per type, which allows clearer compartmentalisation of variables and code.
Improves loading as FreePBX instantiates only once
WIP - create a full class loaded with Sccp_Manager
2021-07-04 16:46:18 +02:00
steve-lad b6dfb51993 Conditional include of Use chan-sccp defaults/Customise button
If there is no chan-sccp default, do not add the button to use chan-sccp default/customise

This adds a large block of html + php enclosed within {}. Add documentation so that this is clear
2021-07-04 09:02:33 +02:00