Commit graph

114 commits

Author SHA1 Message Date
stevenA 968210795f Update ajaxHelper.php 2022-01-21 08:12:10 +01:00
stevenA 485ce3fe3a Add FW and Template availability to sccpdevmodel
Rename menu items
Add new fields to sccpdevmodel to show existence of firmware and template files, thereby reducing load times.
2022-01-21 08:11:14 +01:00
stevenA e9a3bf34df Continued Optimisations and Cleaning
Optimise return values from AMI to avoid reformatting
Simplify validate logic
Optimise treatment of ami raw message
Optimise return values from getDb_model_info and clean up method name
Optimize add device moving functions outside of loop
Define unique names for script methods between SIP and SCCP as in same page
2022-01-21 08:11:08 +01:00
stevenA 4fb0ec58b1 Update ajaxHelper.php
Change selection of phonecodepage depending on phone type (java/non-java)
2022-01-21 08:07:58 +01:00
stevenA 8961ebd5de Optimise aminterface, and calls to it
Only get activeDevices once in doConfigPageInits
Delete redundant functions in Aminterface class
Optimise json handling
2022-01-21 08:04:29 +01:00
stevenA 9138272a46 Remove debug code 2022-01-21 08:04:15 +01:00
stevenA c680ab5bb0 Use doConfigPageInit BMO method
Increase compliance with BMO. Decreases calls and improves responsiveness
2022-01-21 07:58:07 +01:00
stevenA af1725e025 Continued BMO optimisations
Tidy up ajaxHelper
Set correct return values from ajaxHandler
Use BMO __get to minimise construct calls
Implement Module.xml depends
2022-01-21 07:54:51 +01:00
stevenA 9576a17087 Use doConfigPageInit BMO method
Increase compliance with BMO. Decreases calls and improves responsiveness
2022-01-21 07:50:44 +01:00
stevenA b7654a8c75 Remove debug code 2022-01-21 07:45:19 +01:00
stevenA c9839eadc5 Use doConfigPageInit BMO method
Increase compliance with BMO. Decreases calls and improves responsiveness
2022-01-21 07:45:18 +01:00
stevenA 7e50dbf2d2 Continued BMO optimisations
Tidy up ajaxHelper
Set correct return values from ajaxHandler
Use BMO __get to minimise construct calls
Implement Module.xml depends
2022-01-21 07:45:10 +01:00
stevenA a3eb87610c Fix update settings page on save 2022-01-21 07:42:34 +01:00
stevenA ea6b7b3783 Use doConfigPageInit BMO method
Increase compliance with BMO. Decreases calls and improves responsiveness
2022-01-21 07:42:22 +01:00
stevenA 60777bf3e3 Fix saving of custom soft keysets
Red border if invalid set name
Clean up modal indenting
Define valid chars
Only initialise general section at each save (previously initialised all clearing soft key sets)
2022-01-19 13:46:47 +01:00
stevenA 381fe184bd Fix Issue #59
Correct error in update mode selection
Save all buttons, rather than to last empty - buttons do not need to be allocated sequentially
Remove on duplicate case - add should always be new as either device is new, or have deleted device data before.
2022-01-19 12:07:41 +01:00
stevenA d7ad8397da Update ajaxHelper.php 2022-01-19 08:36:57 +01:00
stevenA 4e17791fa1 Change wincharset selection method
Use utf-8 for java based phones
2022-01-17 10:43:50 +01:00
stevenA 3ce99c94d8 Fix reversion - not returning to correct page after save
Settings and device save require different r=treatment on reload after save
2022-01-10 14:00:07 +01:00
stevenA 34d6e976f2 Fix minor issues when saving settings
Page was not reloading correctly
Devices were not restarting (returning too soon)
2022-01-10 11:31:26 +01:00
stevenA 048077fce8 Update SIP device Handling & Fix Issue#53
Fix Issue #53
Consolidate forms to facilitate maintenance, reduce code, and apply changes to SIP handling introduce for sccp
Delete form.addsdevice.php
Delete form.sbuttons.php
Delete sipconfigs class and move db functions to dbinterface class, and other function to helperfunctions
create new field type for SIP line
update 9951 buttons count in installer
simplify segregation of sip and sccp requests
2022-01-06 15:00:24 +01:00
stevenA 1f73ade196 Fix Issue #54
Do not try to write SEP file if no line defined. Save settings and warn user via toast
Fix feedback to ajax by separately submitting data before return
Fix freepbx overwriting data and causing fail, by separating json into two blocks and only parsing the first
Fix return to tab on save (set location hash) when tabs changed in settings
Fix return to calling page on save when device updated
2022-01-04 14:41:43 +01:00
stevenA 198b3fffa8 Update save SIP device
Fail if no valid FreePbx sip bindings available

Fix SIP display issue

Correct line protocol selection
2022-01-02 13:06:41 +01:00
steve-lad 61beae544e
Merge branch 'develop' into Fix-issue-#47 2021-12-30 15:27:15 +01:00
stevenA c473c62ada Fix issue #47 - Defaults toggling with repeated saves
Remove unused group from server.settings.php
Correct testing for use of system defaults
Correct application of system defaults
ToDo:Numeric values are not being saved, or do not revert to defaults when button clicked
2021-12-30 15:22:20 +01:00
stevenA f4aa2eda1c Fix writing settings to sccp.conf
Only write chan-sccp allowed settings to sccp.conf
Clean sccp.conf on install
Move createDefaultSccpConfig to traits so that can access from installer
tighten calls to createDefaultSccpConfig
2021-12-30 09:39:28 +01:00
stevenA 0bc2eed76b Fix dndFeature setting not saved
dndFeature setting was not saved
check for existence of chan-sccp flags
add helper to list chan-sccp flags
fix version compatibility check
update version to 14.3.0.19
2021-12-29 12:42:57 +01:00
steve-lad a2217e6e37 Fix issue #39
Get masterFilesList at install direct from Provisioner. If not available, install a copy from the module
2021-12-27 11:09:42 +01:00
steve-lad 67f2a8b2a3 Quote device name in xpath request
Xpath requires quotes if non numeric device name (eg 894x)
2021-10-14 09:12:57 +02:00
steve-lad 2dc613f063 Fix variable name
arr_data was mistyped
2021-09-21 10:35:10 +02:00
steve-lad 8f6c7be74e Optimise handle submit
Change order of treatment of returned data
Handle db calls outside of loops
Optimise parsing
2021-08-15 13:07:36 +02:00
steve-lad b7d5851643 Update helperFunctions.php 2021-08-10 08:06:36 +02:00
steve-lad 031ef0087e Compatibility update 2021-08-09 13:56:18 +02:00
steve-lad 91d6ad2f48 Fix incompatibility with new Describe table 2021-08-09 09:23:00 +02:00
steve-lad 0b03d58c09 Remove debug code and update version 2021-08-08 09:57:36 +02:00
steve-lad 481c8929a9 Correct handling of device vendor settings
Prefix was incorrect following removal of _column names
2021-08-08 09:56:04 +02:00
steve-lad 8dc1175b37 Update installer to add parent extensions to sccpline if they exist
Previously ignored sccp extensions in freepbx devices and so created 'orphans'. Now create rows for sccpline for devices that already exist as sccp extensions in devices.

Remove dbug code
2021-08-08 09:03:05 +02:00
steve-lad b30340eab5 Update ajaxHelper.php 2021-08-07 16:07:18 +02:00
steve-lad 6775b6686b Simplify getPhoneGrid 2021-08-01 14:54:17 +02:00
steve-lad 4ffcfaf6b7 Correct getExtensionGrid method and optimise
Was dropping last line
Logic was overly complicated; optimise as called frequently
2021-08-01 13:58:11 +02:00
steve-lad 28bb5a63da Optimise validate part of getSccpModelInformation
Remove needless iterations and use array functions.
Use basename to remove file extension to facilitate this
2021-08-01 11:57:03 +02:00
steve-lad ab7b295b87 switch basedir path source
Use $amp_conf['AMPWEBROOT'] instead of $_SERVER['DOCUMENT_ROOT'] as at least in one case the latter appears to be empty
2021-07-31 17:07:37 +02:00
steve-lad d8d2f946ce Minor optimisations 2021-07-31 15:41:32 +02:00
steve-lad 43a656cebc Correct XML Path in installer and optimise findAllFiles
XML Path in installer was in single quotes - corrected
Remove unnecessary tests in findallfiles
2021-07-31 12:30:24 +02:00
steve-lad b7a64e854f Update ajaxHelper.php 2021-07-30 14:05:59 +02:00
steve-lad e8cabfbd1a Improve parsing of firewall rules 2021-07-30 14:05:00 +02:00
steve-lad 472d73489e Update ajaxHelper.php 2021-07-29 17:21:18 +02:00
steve-lad fb25407611 Improve presentation of shared lines 2021-07-29 17:20:43 +02:00
steve-lad b659f55170 Remove _ prefixes in db column names
Mariadb does not accept _prefixed fields by spec, and these columns may give future issues. Migrate all fields in installer to remove this prefix (without data loss) and:
Create new view sccplineconfig for chan-sccp where only accepted fields are shown
Update sccpdeviceconfig to only show accepted fields
Update extconfigs.conf to use sccplineconfig
Remove references to _ prefixed fields
2021-07-28 15:48:57 +02:00
steve-lad 26f750296a Fix various issues with buttons
Add choice of default line on add device
Partially fix buttoncount (will not work if default device is selected)
Correct database save logic for buttons - triggers should be OK but more verification needed
Fix various save issues where defaults not correctly set
Delete default buttons when deleting line to avoid orphans
2021-07-25 13:42:42 +02:00