cleanup

copyparty/httpconn.py

@@ -112,8 +112,6 @@ class HttpConn(object):
         return self.u2idx
 
     def _detect_https(self) -> bool:
-        method = None
-        if True:
         try:
             method = self.s.recv(4, socket.MSG_PEEK)
         except socket.timeout:

copyparty/stolen/ifaddr/_shared.py

@@ -61,7 +61,7 @@ class Adapter(object):
         )
 
 
-if True:
+if True:  # pylint: disable=using-constant-test
     # Type of an IPv4 address (a string in "xxx.xxx.xxx.xxx" format)
     _IPv4Address = str
 

copyparty/up2k.py

@@ -419,7 +419,6 @@ class Up2k(object):
     def _check_lifetimes(self) -> float:
         now = time.time()
         timeout = now + 9001
-        if now:  # diff-golf
         for vp, vol in sorted(self.asrv.vfs.all_vols.items()):
             lifetime = vol.flags.get("lifetime")
             if not lifetime:
@@ -1217,8 +1216,6 @@ class Up2k(object):
             abspath = os.path.join(cdir, fn)
             nohash = reh.search(abspath) if reh else False
 
-            if fn:  # diff-golf
-
             sql = "select w, mt, sz, at from up where rd = ? and fn = ?"
             try:
                 c = db.c.execute(sql, (rd, fn))

copyparty/util.py

@@ -1823,7 +1823,9 @@ def exclude_dotfiles(filepaths: list[str]) -> list[str]:
     return [x for x in filepaths if not x.split("/")[-1].startswith(".")]
 
 
-def odfusion(base: Union[ODict[str, bool], ODict["LiteralString", bool]], oth: str) -> ODict[str, bool]:
+def odfusion(
+    base: Union[ODict[str, bool], ODict["LiteralString", bool]], oth: str
+) -> ODict[str, bool]:
     # merge an "ordered set" (just a dict really) with another list of keys
     words0 = [x for x in oth.split(",") if x]
     words1 = [x for x in oth[1:].split(",") if x]

scripts/docker/README.md

@@ -19,7 +19,7 @@ docker run --rm -it -u 1000 -p 3923:3923 -v /mnt/nas:/w -v $PWD/cfgdir:/cfg copy
 
 this example is also available as a podman-compatible [docker-compose yaml](https://github.com/9001/copyparty/blob/hovudstraum/docs/examples/docker/basic-docker-compose); example usage: `docker-compose up` (you may need to `systemctl enable --now podman.socket` or similar)
 
-i'm unfamiliar with docker-compose and alternatives so let me know if this section could be better 🙏
+i'm not very familiar with containers, so let me know if this section could be better 🙏
 
 
 ## configuration