From fd89f7ecb9f8d96ba1516b18f9ff268def522912 Mon Sep 17 00:00:00 2001 From: ed Date: Wed, 13 Mar 2024 21:49:49 +0000 Subject: [PATCH] idp: abandon idea for persisting idp volumes; too fraught with subtle dangers, such as other copyparty instances ending up sharing knowledge of volumes unintentionally, and configuration becoming mysteriously sticky (not to mention this would all become hella difficult to reason about) instead, rely entirely on users seeing the big red warning added in 2ebfdc25 if their configuration is dangerous this decision has the drawback that there will be server stuttering whenever a new user makes themselves known since the last restart, as it realizes the volumes exist and does the usual e2ds indexing, instead of doing it early during startup but it's probably good enough --- copyparty/authsrv.py | 4 ---- docs/TODO.md | 3 --- 2 files changed, 7 deletions(-) diff --git a/copyparty/authsrv.py b/copyparty/authsrv.py index 19887e38..f8a953e6 100644 --- a/copyparty/authsrv.py +++ b/copyparty/authsrv.py @@ -902,7 +902,6 @@ class AuthSrv(object): mount: dict[str, str], daxs: dict[str, AXS], mflags: dict[str, dict[str, Any]], - only_if_exist: bool = False, ) -> tuple[str, str]: src = os.path.expandvars(os.path.expanduser(src)) src = absreal(src) @@ -923,9 +922,6 @@ class AuthSrv(object): raise Exception(BAD_CFG) if not bos.path.isdir(src): - if only_if_exist: - return ("", "") - self.log("warning: filesystem-path does not exist: {}".format(src), 3) mount[dst] = src diff --git a/docs/TODO.md b/docs/TODO.md index befcedf4..b199f584 100644 --- a/docs/TODO.md +++ b/docs/TODO.md @@ -7,9 +7,6 @@ a living list of upcoming features / fixes / changes, very roughly in order of p * reverseproxy/cloudflare: ensure cloudflare does not terminate https * docker: suggest putting hists in /cfg/hists/ -* [github issue #62](https://github.com/9001/copyparty/issues/62) - IdP / single-sign-on powered by a local identity provider service which is possibly hooked up to ldap or an oauth service - * persist autogenerated volumes for db-init + nullmapping on next startup (`_map_volume` += `only_if_exist`) - * download accelerator * definitely download chunks in parallel * maybe resumable downloads (chrome-only, jank api)