Diederik de Groot
8bdd6beee8
Couple of small changes
2021-05-24 15:55:24 +02:00
steve-lad
cd30a20cf6
Update README.md
...
Reflect move of sccp_manager to chan-sccp, updating links and readme.
2021-05-24 15:14:55 +02:00
steve-lad
12c8f30464
Fix Issue with SQL syntax reported by kc2vrj
...
Correct quotation and simplify logic to avoid complex SQL statements.
Bind strings
Confirmed fix of issue reported by kc2vrj.
2021-05-24 13:55:36 +02:00
Diederik de Groot
0011581fc0
Merge branch 'PR108' into extension_mobility_rebased_on_develop
2021-05-24 13:46:19 +02:00
steve-lad
d451b36363
Fix Issue with SQL syntax reported by kc2vrj
...
Correct quotation and simplify logic to avoid complex SQL statements.
Bind strings
Confirmed fix of issue reported by kc2vrj.
2021-04-29 16:44:33 +02:00
Diederik de Groot
9e95071bad
Fix: Default models should have at least 1 button if number is currently no known
...
Enh: allow all model information to be edited.
Fix: edit/load loadinformationid
Fix: Modal Title -> Model
With help from @steve-lad
References: #91
Signed-off-by: Diederik de Groot <dkgroot@talon.nl>
2021-04-02 15:30:03 +02:00
Diederik de Groot
07be691c16
parse outboundcid content into cid_num and cid_name sccpline fields
...
If outboundcid contains '"name" <num>' the content needs to be split to cid_name and cid_num.
If not the content should be a number and should be copied to cid_num only, in that case we fill cid_name with the value of $label
Fixes : #72
Signed-off-by: Diederik de Groot <dkgroot@talon.nl>
2021-04-02 15:30:03 +02:00
Diederik de Groot
1ef1fe1e31
Move the disallow box to the top of the form, the order is important.
...
Signed-off-by: Diederik de Groot <dkgroot@talon.nl>
2021-04-02 15:30:02 +02:00
steve-lad
7f93f0179b
Remove PHP % incompatible code
2021-04-02 15:29:36 +02:00
steve-lad
8fb29b93fd
Update dbinterface.class.php
...
Correct syntax
2021-04-02 15:29:36 +02:00
steve-lad
ef4fc4fe12
Fix Sccp Button Save
...
Correct PDO statements and implimentation concept
2021-04-02 15:29:36 +02:00
steve-lad
9f5459f7c5
Update dbinterface.class.php
...
Check that labels exist before binding or an exception will occur
2021-04-02 15:29:36 +02:00
steve-lad
bd257cec9b
Correct string quoting
...
String quoting was incompatible with PHP 7
2021-04-02 15:29:36 +02:00
steve-lad
594367cbd4
Update dbinterface.class.php
...
Bug fix
2021-04-02 15:29:36 +02:00
steve-lad
31ac0746ba
Bug fixes
...
Correct SQL statement
Correct Message Handler
Correct Message interpreter
2021-04-02 15:29:36 +02:00
steve-lad
e1c6a1d39b
Remove tmp nfs files
2021-04-02 15:29:36 +02:00
steve-lad
c4cd6cbdbf
Update install.php
...
Populate sccpdevmodel if empty
2021-04-02 15:29:36 +02:00
steve-lad
3ed43600d4
Merge Fix-dbinterface-class
2021-04-02 15:29:36 +02:00
steve-lad
36192599f1
Migrate from global db object
...
As per FreePBX BMO, no longer use global db object
2021-04-02 15:29:34 +02:00
steve-lad
f4f11157e1
Fix exception if sccpsettings table does not exist
...
Before the installer can create sccpsettings, FreePBX instantiates an SCCP_Manager object which requires sccpsettings.
Catch the exception and create the table
2021-04-02 15:29:17 +02:00
steve-lad
d3ae6536d1
Update dbinterface.class.php
2021-04-02 15:29:17 +02:00
steve-lad
19e1bb9b3e
Remove dbugs
2021-04-02 15:29:17 +02:00
steve-lad
dac622c745
Final version
...
Standardise some calls and add notes
2021-04-02 15:29:15 +02:00
steve-lad
09beeb449e
Use bindParam on db executes
...
Use bind param to have stricter typing
Fix bug in Sccp-Manager where key and keyword were not the same
2021-04-02 15:28:55 +02:00
steve-lad
5892afc653
Update Transactions and fix errors
...
Reduce quoting level, and fix errors introduced by prior commits
2021-04-02 15:28:54 +02:00
steve-lad
4a3f21dc5d
Further clean ups and annotations
...
Document changes
2021-04-02 15:28:35 +02:00
steve-lad
cfcbe23816
Switch to PDO model
...
Switch to PDO model and correct transactions
2021-04-02 15:28:06 +02:00
steve-lad
fd8c5f9f96
Cleaning up
...
Simplify structure and fix errors
2021-04-02 15:27:28 +02:00
steve-lad
a1c020c772
Switch to PDO model
...
Switch to PDO model and correct transactions
2021-04-02 15:27:27 +02:00
steve-lad
c77c8b76cc
Test for chan_sccp_b version compatibility
...
SoftKeySets fails with chan_sccp-b prior to revision number 11048.
Check the version with the installer, and subsequently to ensure do not get exception.
2021-04-02 15:25:56 +02:00
steve-lad
91c2d233d4
Use bindParam on db executes
...
Use bind param to have stricter typing
Fix bug in Sccp-Manager where key and keyword were not the same
2021-04-02 15:25:32 +02:00
steve-lad
3fbccb982f
Update Transactions and fix errors
...
Reduce quoting level, and fix errors introduced by prior commits
2021-04-02 15:25:32 +02:00
steve-lad
7f047f7c10
Further clean ups and annotations
...
Document changes
2021-04-02 15:25:31 +02:00
steve-lad
bda7518932
Cleaning up
...
Simplify structure and fix errors
2021-04-02 15:25:31 +02:00
steve-lad
95405190cc
Switch to PDO model
...
Switch to PDO model and correct transactions
2021-04-02 15:25:31 +02:00
steve-lad
92ca19ed41
Test for chan_sccp_b version compatibility
...
SoftKeySets fails with chan_sccp-b prior to revision number 11048.
Check the version with the installer, and subsequently to ensure do not get exception.
2021-04-02 15:25:30 +02:00
steve-lad
9d29d11a08
Apply PR 101
2021-04-02 15:23:55 +02:00
steve-lad
40e9b01510
Correct type declarations
...
type declarations must be lowercase or will be treated as local instance names
2021-04-02 15:23:55 +02:00
steve-lad
e94fa4e8d1
Tidy up
...
Remove unused variables
Close socket if not using
2021-04-02 15:23:55 +02:00
steve-lad
673f6d45e0
Tighten Ami controls
...
Check that have compatible version of chan-sccp for AMI and disable AMI if not found
Check returned values
Add new classes for response to reduce testing
2021-04-02 15:23:54 +02:00
steve-lad
315a693894
Correct Field and add new event classes
...
add 2 new event classes for SCCPShowDevice
correct translator in ShowSCCPDevice_Response
2021-04-02 15:23:54 +02:00
steve-lad
5beee7f9a2
Tidy up exception handling
...
Simplify handling of AMI lists and trap exceptions
2021-04-02 15:23:54 +02:00
steve-lad
a89866e81e
Bug Fixes and optimisations as a result of issue 106
...
Fix bugs in Response Class causing exceptions
Update extconfigs class to correctly check database connectors and improve feedback
Move some constructors to start of class for lisibility
Tidy up Response class with Typing to eliminate unnecessary tests
2021-04-02 15:23:54 +02:00
Andrea Diotallevi
9b730a998a
Fixed recognition of chan-sccp release version 4.3.3
2021-04-02 15:23:54 +02:00
steve-lad
ca5cf9571b
Updated GenericResponse
...
Updated generic response handler for table case
2021-04-02 15:23:54 +02:00
steve-lad
929f8036b1
Update AMI Response
...
Bring branch up to level of previous Pull which can now be deleted
2021-04-02 15:23:54 +02:00
steve-lad
6ccc9bbccb
Cleaned up messages
...
Improved message readability. Atom removed extraneous white spaces and lines
2021-04-02 15:23:54 +02:00
steve-lad
2f69bdb3fa
Match to previous commit
...
Add missing comments
2021-04-02 15:23:54 +02:00
steve-lad
11af87ca38
Remove extraneous calls
...
Duplicate calls from page.settings removed
2021-04-02 15:23:53 +02:00
steve-lad
e4a4630ad2
Installer failed to update db version
...
Error in sytax at 745, and in exception handler at 747
Tidied up messages
Standardised Exception handler trap
Atom deleted whitespaces
2021-04-02 15:23:53 +02:00