mirrors/copyparty
1
0
Fork 0
mirror of https://github.com/9001/copyparty.git synced 2025-08-17 09:02:15 -06:00
Code Issues Actions Packages Projects Releases Wiki Activity

idp: abandon idea for persisting idp volumes;

Browse source 
too fraught with subtle dangers, such as other copyparty instances
ending up sharing knowledge of volumes unintentionally, and
configuration becoming mysteriously sticky (not to mention
this would all become hella difficult to reason about)

instead, rely entirely on users seeing the big red warning
added in 2ebfdc25 if their configuration is dangerous

this decision has the drawback that there will be server stuttering
whenever a new user makes themselves known since the last restart,
as it realizes the volumes exist and does the usual e2ds indexing,
instead of doing it early during startup

but it's probably good enough
This commit is contained in:
ed 2024-03-13 21:49:49 +00:00
parent 2ebfdc2562
commit fd89f7ecb9
2 changed files with 0 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
copyparty/authsrv.py
View file

@ -902,7 +902,6 @@ class AuthSrv(object):
mount: dict[str, str], mount: dict[str, str],
daxs: dict[str, AXS], daxs: dict[str, AXS],
mflags: dict[str, dict[str, Any]], mflags: dict[str, dict[str, Any]],
only_if_exist: bool = False,
) -> tuple[str, str]: ) -> tuple[str, str]:
src = os.path.expandvars(os.path.expanduser(src)) src = os.path.expandvars(os.path.expanduser(src))
src = absreal(src) src = absreal(src)
@ -923,9 +922,6 @@ class AuthSrv(object):
raise Exception(BAD_CFG) raise Exception(BAD_CFG)
if not bos.path.isdir(src): if not bos.path.isdir(src):
if only_if_exist:
return ("", "")
self.log("warning: filesystem-path does not exist: {}".format(src), 3) self.log("warning: filesystem-path does not exist: {}".format(src), 3)
mount[dst] = src mount[dst] = src

3
docs/TODO.md
View file

@ -7,9 +7,6 @@ a living list of upcoming features / fixes / changes, very roughly in order of p
* reverseproxy/cloudflare: ensure cloudflare does not terminate https * reverseproxy/cloudflare: ensure cloudflare does not terminate https
* docker: suggest putting hists in /cfg/hists/ * docker: suggest putting hists in /cfg/hists/
* [github issue #62](https://github.com/9001/copyparty/issues/62) - IdP / single-sign-on powered by a local identity provider service which is possibly hooked up to ldap or an oauth service
* persist autogenerated volumes for db-init + nullmapping on next startup (`_map_volume` += `only_if_exist`)
* download accelerator * download accelerator
* definitely download chunks in parallel * definitely download chunks in parallel
* maybe resumable downloads (chrome-only, jank api) * maybe resumable downloads (chrome-only, jank api)